----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18722/#review36446 -----------------------------------------------------------
When running "make check", this change causes a compilation error on OSX (clang). ../configure make check /bin/sh ../libtool --tag=CXX --mode=compile g++ -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. -I../../../../3rdparty/libprocess/3rdparty -Igmock-1.6.0/gtest/include -Igmock-1.6.0/gtest -Igmock-1.6.0/include -Igmock-1.6.0 -g -g2 -O2 -std=c++11 -stdlib=libc++ -MT libgmock_la-gtest-all.lo -MD -MP -MF .deps/libgmock_la-gtest-all.Tpo -c -o libgmock_la-gtest-all.lo `test -f 'gmock-1.6.0/gtest/src/gtest-all.cc' || echo '../../../../3rdparty/libprocess/3rdparty/'`gmock-1.6.0/gtest/src/gtest-all.cc libtool: compile: g++ -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" "-DPACKAGE_STRING=\"libprocess 0.0.1\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. -I../../../../3rdparty/libprocess/3rdparty -Igmock-1.6.0/gtest/include -Igmock-1.6.0/gtest -Igmock-1.6.0/include -Igmock-1.6.0 -g -g2 -O2 -std=c++11 -stdlib=libc++ -MT libgmock_la-gtest-all.lo -MD -MP -MF .deps/libgmock_la-gtest-all.Tpo -c gmock-1.6.0/gtest/src/gtest-all.cc -fno-common -DPIC -o libgmock_la-gtest-all.o In file included from gmock-1.6.0/gtest/src/gtest-all.cc:39: In file included from gmock-1.6.0/gtest/include/gtest/gtest.h:57: In file included from gmock-1.6.0/gtest/include/gtest/internal/gtest-internal.h:40: gmock-1.6.0/gtest/include/gtest/internal/gtest-port.h:499:13: fatal error: 'tr1/tuple' file not found Without having looked into it very carefully right now, I suspect gmock testing for a gcc-version rather than a language version. - Till Toenshoff On March 4, 2014, 1:36 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18722/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 1:36 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-750 > https://issues.apache.org/jira/browse/MESOS-750 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > gtest's tr1::tuple conficts with std::tr1::tuple for gcc-4.4. However, we use > tuple throughout mesos so we assume tr1::tuple or tuple is available. As > such, we don't need gtest to define one. > > > Diffs > ----- > > configure.ac a84b9609e39dd9b76e293e650e076be359a719db > > Diff: https://reviews.apache.org/r/18722/diff/ > > > Testing > ------- > > export CXX=g++-4.4; export CC=gcc-4.4; ./bootstrap && cd build && > ../configure --with-cxx11 && make check > export CXX=g++-4.4; export CC=gcc-4.4; ./bootstrap && cd build && > ../configure && make check > > > Thanks, > > Dominic Hamon > >
