----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18368/#review36330 -----------------------------------------------------------
src/log/catchup.cpp <https://reviews.apache.org/r/18368/#comment67295> If lower == upper, doesn't seem like we should be catching up the lower position! src/log/catchup.cpp <https://reviews.apache.org/r/18368/#comment67296> Oh.. ok I see why we should consider renaming these catchup functions, feel free to do so if you wan to clean this up. src/log/replica.cpp <https://reviews.apache.org/r/18368/#comment67294> Do you want this TODO in the header? src/log/replica.cpp <https://reviews.apache.org/r/18368/#comment67293> I don't think you need this comment, how about something more succinct? if (from > to) { // Empty interval. return ...; } - Ben Mahler On March 5, 2014, 8:15 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18368/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 8:15 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/catchup.hpp 45dc016 > src/log/catchup.cpp dae4619 > src/log/coordinator.cpp 6bfff1e > src/log/recover.cpp 3403b47 > src/log/replica.hpp 08ddcb1 > src/log/replica.cpp 1f1a945 > src/log/storage.hpp c0eba1b > src/tests/log_tests.cpp 7f2a740 > > Diff: https://reviews.apache.org/r/18368/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
