> On March 11, 2014, 12:05 p.m., Dominic Hamon wrote: > > support/cpplint.py, line 3573 > > <https://reviews.apache.org/r/19060/diff/1/?file=516611#file516611line3573> > > > > we should also start putting test sources alongside the sources they > > test if we want this method to do anything useful.
Fair enough. Removed the comment. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19060/#review36826 ----------------------------------------------------------- On March 11, 2014, 12:24 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19060/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 12:24 p.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1080 > https://issues.apache.org/jira/browse/MESOS-1080 > > > Repository: mesos-git > > > Description > ------- > > Updated cpplint.py from > https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and > added hpp files as valid extensions. > > > Diffs > ----- > > support/cpplint.py a8c9f67 > > Diff: https://reviews.apache.org/r/19060/diff/ > > > Testing > ------- > > Ran cpplint.py with all rules enabled on some of my recent changes; found > style errors in hpp headers. > Ran mesos-style.py on all of mesos source. Found tabs in some > libprocess/stout headers. > > > Thanks, > > Adam B > >
