-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
-----------------------------------------------------------

(Updated March 25, 2014, 1:33 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.


Changes
-------

Oops, forgot to include hpp changes in actual cpplint.py in diff 4.
Updated with diff 5, where cpplint.py is already patched for hpp's and ready to 
lint them out of the box (no patch/make step required).


Bugs: MESOS-1080
    https://issues.apache.org/jira/browse/MESOS-1080


Repository: mesos-git


Description
-------

Updated cpplint.py from 
https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added 
hpp files as valid extensions.


Diffs (updated)
-----

  support/cpplint.patch PRE-CREATION 
  support/cpplint.py a8c9f67 

Diff: https://reviews.apache.org/r/19060/diff/


Testing
-------

Ran cpplint.py with all rules enabled on some of my recent changes; found style 
errors in hpp headers.
Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout 
headers.


Thanks,

Adam B

Reply via email to