-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
-----------------------------------------------------------
(Updated March 14, 2014, 3:14 p.m.)
Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
Changes
-------
Created cpplint.patch to be applied to future updates to cpplint.py from google.
Added a brief comment about what mesos-specific changes are included in my
patch.
Left the hpp changes in cpplint.py, so new clones will not need to run a make
command before running cpplint/mesos-style.
ReviewBoard still ignores my chmod changes from the diff:
diff --git a/support/mesos-style.py b/support/mesos-style.py
old mode 100644
new mode 100755
This may need to be applied manually by the committer?
Bugs: MESOS-1080
https://issues.apache.org/jira/browse/MESOS-1080
Repository: mesos-git
Description
-------
Updated cpplint.py from
https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added
hpp files as valid extensions.
Diffs (updated)
-----
support/cpplint.patch PRE-CREATION
support/cpplint.py a8c9f67
Diff: https://reviews.apache.org/r/19060/diff/
Testing
-------
Ran cpplint.py with all rules enabled on some of my recent changes; found style
errors in hpp headers.
Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout
headers.
Thanks,
Adam B
