----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19090/#review36903 -----------------------------------------------------------
Can you add a test for this? src/master/drf_sorter.hpp <https://reviews.apache.org/r/19090/#comment68094> s/choosen/chosen/ src/master/drf_sorter.cpp <https://reviews.apache.org/r/19090/#comment68095> Does this value grow unbounded? Its probably ok because even with a 1s allocation rate it is going to take lots of years before it wraps around :) - Vinod Kone On March 12, 2014, 5:04 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19090/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 5:04 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1086 > https://issues.apache.org/jira/browse/MESOS-1086 > > > Repository: mesos-git > > > Description > ------- > > See bug for more description. > > > Diffs > ----- > > src/master/drf_sorter.hpp f3fab71424fa10f87c87b733cc678fd90579a814 > src/master/drf_sorter.cpp bbf8270603e26a1b63e0f96bd5aa9c4ee4eb6d25 > > Diff: https://reviews.apache.org/r/19090/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
