----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19090/#review36923 -----------------------------------------------------------
src/master/drf_sorter.cpp <https://reviews.apache.org/r/19090/#comment68109> style question for my edification: why not client.name = it->name; src/master/drf_sorter.cpp <https://reviews.apache.org/r/19090/#comment68110> client.allocations = it->allocations + 1; src/master/drf_sorter.cpp <https://reviews.apache.org/r/19090/#comment68111> a vector would be more cache friendly for iteration, and would allow you to reserve the size of clients here to avoid allocations in the loop below. - Dominic Hamon On March 11, 2014, 10:04 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19090/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 10:04 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1086 > https://issues.apache.org/jira/browse/MESOS-1086 > > > Repository: mesos-git > > > Description > ------- > > See bug for more description. > > > Diffs > ----- > > src/master/drf_sorter.hpp f3fab71424fa10f87c87b733cc678fd90579a814 > src/master/drf_sorter.cpp bbf8270603e26a1b63e0f96bd5aa9c4ee4eb6d25 > > Diff: https://reviews.apache.org/r/19090/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
