> On March 12, 2014, 5:33 p.m., Ian Downes wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 38 > > <https://reviews.apache.org/r/19162/diff/1/?file=517809#file517809line38> > > > > shouldn't we be escaping keys/values... > > > > setenv technically isn't async-signal-safe but that could be used in > > the child > > > > or, even better, we should use execle rather than execl > >
If you can give me some examples of key/values that you think would be problematic i can make sure we have tests for them. I was thinking any values containing special characters can be explicitly quoted (as in the test with spaces). using execle actually solves many of these problems and will, i think, remove the need for quotes in multiple URLs from the containerizer... > On March 12, 2014, 5:33 p.m., Ian Downes wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 52 > > <https://reviews.apache.org/r/19162/diff/1/?file=517808#file517808line52> > > > > I thought we always named all arguments in the codebase? Apparently not consistently for friend methods - I'm following what was here, see also stout/os/process.hpp. Adding some here though. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19162/#review37021 ----------------------------------------------------------- On March 12, 2014, 4:26 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19162/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 4:26 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/subprocess.hpp > d16cbc1e3d464e1784f116ccdb327cf0784f07c2 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > d15d4d159105474117c4ea432b215431209ab539 > > Diff: https://reviews.apache.org/r/19162/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
