----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19162/#review37137 -----------------------------------------------------------
3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19162/#comment68484> Please put '{' on a new line. 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19162/#comment68485> We don't indent these. 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19162/#comment68486> Add a newline. 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19162/#comment68504> Let's move this to .cpp now. 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19162/#comment68489> We indent by +2 here, only +4 for parameter and argument lists. 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/19162/#comment68494> Indent +2 here, and both on their own line please. Also, what about adding a comment at the end of the 'size_' line that explains the +1. 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/19162/#comment68510> s/envi/index/ 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/19162/#comment68512> s/kv/entry/ 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/19162/#comment68490> Newline. 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/19162/#comment68493> Please put each of these on their own line. 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/19162/#comment68495> s/(char *)NULL/(char*) NULL/ - Benjamin Hindman On March 13, 2014, 5:59 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19162/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 5:59 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/subprocess.hpp > d16cbc1e3d464e1784f116ccdb327cf0784f07c2 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > d15d4d159105474117c4ea432b215431209ab539 > > Diff: https://reviews.apache.org/r/19162/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
