----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19162/#review37167 -----------------------------------------------------------
3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19162/#comment68574> How about s/env/environment/ to keep things consistent with the rest of our code, in which we try to avoid abbreviations. 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19162/#comment68576> Can you move this to the .cpp file and just test that subprocess does the right thing with the environment? It seems a little messy to expose this implementation detail especially given how trivial the test is. What does 'Envp' mean? A comment would be nice! 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/19162/#comment68575> What does "= delete" mean? Perhaps use the same comment from other places in the code: // Not copyable, not assignable. Promise(const Promise<T>&); Promise<T>& operator = (const Promise<T>&); 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/19162/#comment68578> Anonymous namespaces are, as far as I know, new style in libprocess. Did you need this? 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/19162/#comment68583> Why are you using 'malloc', instead of 'new'? That is, if you need to, a comment would be nice! - Ben Mahler On March 14, 2014, 12:46 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19162/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 12:46 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/subprocess.hpp > d16cbc1e3d464e1784f116ccdb327cf0784f07c2 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > d15d4d159105474117c4ea432b215431209ab539 > > Diff: https://reviews.apache.org/r/19162/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
