> On March 13, 2014, 11:52 a.m., Adam B wrote: > > src/launcher/executor.cpp, line 60 > > <https://reviews.apache.org/r/18601/diff/1/?file=506577#file506577line60> > > > > Shouldn't need the default argv=NULL in both CommandExecutor and > > CommandExecutorProcess. Pick one entry point for the default value > > (probably the public-facing CommandExecutor), and make the value required > > elsewhere (CommandExecutorProcess).
Good point! Fixed. > On March 13, 2014, 11:52 a.m., Adam B wrote: > > src/launcher/executor.cpp, line 169 > > <https://reviews.apache.org/r/18601/diff/1/?file=506577#file506577line169> > > > > argv will always trump a provided task.command()? This should be > > documented somewhere. And if both are provided, perhaps we should warn that > > task.command() is being overridden by argv. This is the purpose of the RR :) The command to be executed will be printed out, so will drop this issue. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18601/#review37084 ----------------------------------------------------------- On March 13, 2014, 1:10 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18601/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 1:10 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > As discussed during the architecture discussion for pluggable > containerization(see https://issues.apache.org/jira/browse/MESOS-816), we > proposed that the command executor could be exposed for (the slightly unusual > use-case) of launching containers. > This is important in particular, when launching containers which can be > considered _being_ the command, for example a docker image which runs the > necessary services (mysql, memcache and so on) through it's usual init system. > We therefore need a way start the command executor with this use-case in > mind. This patch adds support for passing and overwriting the command to > launch from the command line. > > > Diffs > ----- > > src/launcher/executor.cpp e30d77a > > Diff: https://reviews.apache.org/r/18601/diff/ > > > Testing > ------- > > Usual behavior of mesos-executor doesn't change. This is used and has been > tested with https://github.com/mesosphere/deimos. > > > Thanks, > > Niklas Nielsen > >
