> On March 21, 2014, 2:37 p.m., Ian Downes wrote: > > src/launcher/executor.cpp, line 60 > > <https://reviews.apache.org/r/18601/diff/2/?file=518952#file518952line60> > > > > Can you document this, especially the semantics for argv == NULL. > > > > This feels a little weird to me. Perhaps, introduce a flag to > > mesos-executor which determines this behavior? > > > > const char** const?
Ok - how about something like "--overwrite-task" followed by the command? And would that fit in main() or somewhere else? Good point on the char type, but I think it should be "char* const*" to work with execvp. > On March 21, 2014, 2:37 p.m., Ian Downes wrote: > > src/launcher/executor.cpp, line 171 > > <https://reviews.apache.org/r/18601/diff/2/?file=518952#file518952line171> > > > > what about swapping these blocks to put the common case first? Good point. Thanks! > On March 21, 2014, 2:37 p.m., Ian Downes wrote: > > src/launcher/executor.cpp, line 303 > > <https://reviews.apache.org/r/18601/diff/2/?file=518952#file518952line303> > > > > const char** const? Changed to char* const* > On March 21, 2014, 2:37 p.m., Ian Downes wrote: > > src/launcher/executor.cpp, line 313 > > <https://reviews.apache.org/r/18601/diff/2/?file=518952#file518952line313> > > > > ditto ditto - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18601/#review38206 ----------------------------------------------------------- On March 21, 2014, 3:15 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18601/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 3:15 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > As discussed during the architecture discussion for pluggable > containerization(see https://issues.apache.org/jira/browse/MESOS-816), we > proposed that the command executor could be exposed for (the slightly unusual > use-case) of launching containers. > This is important in particular, when launching containers which can be > considered _being_ the command, for example a docker image which runs the > necessary services (mysql, memcache and so on) through it's usual init system. > We therefore need a way start the command executor with this use-case in > mind. This patch adds support for passing and overwriting the command to > launch from the command line. > > > Diffs > ----- > > src/launcher/executor.cpp e30d77a > > Diff: https://reviews.apache.org/r/18601/diff/ > > > Testing > ------- > > Usual behavior of mesos-executor doesn't change. This is used and has been > tested with https://github.com/mesosphere/deimos. > > > Thanks, > > Niklas Nielsen > >
