----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18601/#review38206 -----------------------------------------------------------
src/launcher/executor.cpp <https://reviews.apache.org/r/18601/#comment70206> Can you document this, especially the semantics for argv == NULL. This feels a little weird to me. Perhaps, introduce a flag to mesos-executor which determines this behavior? const char** const? src/launcher/executor.cpp <https://reviews.apache.org/r/18601/#comment70210> I don't think stringify() can do anything useful with a char**? src/launcher/executor.cpp <https://reviews.apache.org/r/18601/#comment70219> what about swapping these blocks to put the common case first? src/launcher/executor.cpp <https://reviews.apache.org/r/18601/#comment70216> Perhaps comment on this reuse of the first argument for the pathname and argv[0]? src/launcher/executor.cpp <https://reviews.apache.org/r/18601/#comment70211> const char** const? src/launcher/executor.cpp <https://reviews.apache.org/r/18601/#comment70220> ditto - Ian Downes On March 21, 2014, 4:34 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18601/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 4:34 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > As discussed during the architecture discussion for pluggable > containerization(see https://issues.apache.org/jira/browse/MESOS-816), we > proposed that the command executor could be exposed for (the slightly unusual > use-case) of launching containers. > This is important in particular, when launching containers which can be > considered _being_ the command, for example a docker image which runs the > necessary services (mysql, memcache and so on) through it's usual init system. > We therefore need a way start the command executor with this use-case in > mind. This patch adds support for passing and overwriting the command to > launch from the command line. > > > Diffs > ----- > > src/launcher/executor.cpp e30d77a > > Diff: https://reviews.apache.org/r/18601/diff/ > > > Testing > ------- > > Usual behavior of mesos-executor doesn't change. This is used and has been > tested with https://github.com/mesosphere/deimos. > > > Thanks, > > Niklas Nielsen > >
