> On March 20, 2014, 1 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 48-49 > > <https://reviews.apache.org/r/19162/diff/7/?file=528493#file528493line48> > > > > What does '// = delete' mean? Do you still need this now that you've > > added the comment about what you're trying to restrict?
it's ready for C++11. When we have that required we can comment this in and explicitly delete the constructors, as opposed to just not defining them. > On March 20, 2014, 1 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 71-72 > > <https://reviews.apache.org/r/19162/diff/7/?file=528493#file528493line71> > > > > Would be nice to avoid the need for static_cast and sizeof by just > > using 'new' in Envp, any reason not to clean it up? > > > > Ditto for calloc. i tend to avoid new[] for basic types, but that's a hangover from too much kernel coding :P > On March 20, 2014, 1 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp, line 10 > > <https://reviews.apache.org/r/19162/diff/7/?file=528494#file528494line10> > > > > System C includes go before C++ includes, can you revert the move? gmock is not a system include, it's third party. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19162/#review37860 ----------------------------------------------------------- On March 20, 2014, 4:20 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19162/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 4:20 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > 75b2a96b3ca62a4a59e64aba046f1d797bd8ebf6 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > d15d4d159105474117c4ea432b215431209ab539 > > Diff: https://reviews.apache.org/r/19162/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
