> On March 20, 2014, 8 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp, line 10 > > <https://reviews.apache.org/r/19162/diff/7/?file=528494#file528494line10> > > > > System C includes go before C++ includes, can you revert the move? > > Dominic Hamon wrote: > gmock is not a system include, it's third party.
Let's keep it consistent with the rest of the code for now, and open a conversation to update the code if it makes sense. :) > On March 20, 2014, 8 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 48-49 > > <https://reviews.apache.org/r/19162/diff/7/?file=528493#file528493line48> > > > > What does '// = delete' mean? Do you still need this now that you've > > added the comment about what you're trying to restrict? > > Dominic Hamon wrote: > it's ready for C++11. When we have that required we can comment this in > and explicitly delete the constructors, as opposed to just not defining them. Ah I see, let's just keep this consistent with the rest of the code as well and make the '= delete' change in one swoop when we introduce the C++11 requirement. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19162/#review37860 ----------------------------------------------------------- On March 20, 2014, 11:20 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19162/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 11:20 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp > 75b2a96b3ca62a4a59e64aba046f1d797bd8ebf6 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > d15d4d159105474117c4ea432b215431209ab539 > > Diff: https://reviews.apache.org/r/19162/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
