> On March 19, 2014, 7:45 p.m., Vinod Kone wrote: > > Can we add some tests around the new refactor (e.g., race conditions > > mentioned in the review)? That would make us confident that we are not > > regressing here, because this is a significant change. > > Niklas Nielsen wrote: > Hey Vinod - thanks a lot for looking at this! > > But I think we just missed each other; I uploaded a new patch before you > got to publish your review. > I will post a new patch based on your recent comments and ping you :)
No worries. I'm looking forward to landing this patch as this makes it easy to work with external containerizers :) Can you also try it split this into multiple reviews? Some I could think of 1) Name change for executorStarted to executorLaunched 2) Making ExecutorInfo a Future. 3) Moving executor launch inside the Containerizer. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18403/#review37753 ----------------------------------------------------------- On March 19, 2014, 7:46 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18403/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 7:46 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-922 > https://issues.apache.org/jira/browse/MESOS-922 > > > Repository: mesos-git > > > Description > ------- > > This patch delegates the choice of executor to the containerizer by removing > executorInfo dependencies up until Containerizer::launch(). > Containerizer::launch() now returns a future to the executor info that is > being run and the slave creates the corresponding executor structure when > launch completes. > This means message handling from the running executor to the slave in the > interim where the executor structure has not created, need to be enqueued > until executor is ready. So far, registerExecutor() and reregisterExecutor() > has been split into two continuations to deal with this issue. > > > Diffs > ----- > > src/slave/containerizer/containerizer.hpp d9ae326 > src/slave/containerizer/mesos_containerizer.hpp ee1fd30 > src/slave/containerizer/mesos_containerizer.cpp c819c97 > src/slave/http.cpp 594032d > src/slave/slave.hpp 01b80df > src/slave/slave.cpp d8d3e0f > src/tests/containerizer.hpp 5686398 > src/tests/containerizer.cpp bfb9341 > > Diff: https://reviews.apache.org/r/18403/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
