> On March 26, 2014, 5:34 p.m., Benjamin Hindman wrote: > > Sorry I haven't been able to get to this sooner! I'm fine with > > --disable-bundled not falling back on bundled dependencies since there is > > an escape hatch where someone can explicitly specify which bundled > > dependencies _to not_ use (and thus, which ones _to_ use).
To be clear about this escape hatch, this is what I had in mind: configure --without-bundled-zookeeper # builds with bundled leveldb configure --without-bundled-leveldb # builds with bundled zookeeper Alternatively, we could support: configure --disable-bundled --with-bundled-leveldb # builds with bundled leveldb configure --disable-bundled --with-bundled-zookeeper # builds with bundled zookeeper To Tim's point, if someone specifies --disable-bundled and there aren't appropriate system dependencies then failing sounds fine, but it could make sense to be able to 'override' the --disable-bundled explicitly (not automagically as had been proposed via "fallback"). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review38626 ----------------------------------------------------------- On March 26, 2014, 3:50 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18957/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 3:50 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1071 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --disable-bundled generally switches from bundled to preinstalled libraries. > > If --disable-bundled is supplied or --with-leveldb[=DIR] or > --without-included-leveldb was given but the configuration phase could not > locate the dependency, it stops with an error. > If --disable-bundled is not supplied and no --with-leveldb[=DIR] or > --without-included-leveldb was given, the bundled library is built and used. > > --without-included-leveldb and --with-leveldb without a path are semantically > equal. > > NOTE: This review only implements this preinstalled library usage on LevelDB. > Subsequent review requests for other bundled libraries will follow as soon as > this implementation has been accepted. > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac 5404dc2 > src/Makefile.am 47d03b3 > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/18957/diff/ > > > Testing > ------- > > ../configure > make check > > installed leveldb in custom location > ../configure --with-leveldb=/CUSTOM_LOCATION > make check > > installed leveldb in common location > ../configure --with-leveldb > make check > > installed leveldb in common location > ../configure --without-included-leveldb > make check > > installed leveldb in common location > ../configure --disable-bundled > make check > > > Thanks, > > Till Toenshoff > >
