----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18957/#review38624 -----------------------------------------------------------
I'm still a bit confused about the preference order here. I'm assuming the description on this review is out of date after the latest changes. Can you update it? Talking with BenH, he suggested getting rid of --with-foo="/path" in favor of explicitly setting CPP and LD flags. That would definitely make it simpler to reason about the preferences. Ultimately the most flexible would be having the ability to specify these preferences both globally (default) and per package (overrides default): --> system-only --> bundled-only --> prefer system over bundled --> prefer bundled over system Is this easy to accomplish? configure.ac <https://reviews.apache.org/r/18957/#comment70878> looking at how zookeeper is setup above shouldn't this be s/without/with/ ? configure.ac <https://reviews.apache.org/r/18957/#comment70879> is this correct? configure.ac <https://reviews.apache.org/r/18957/#comment70882> s/attempt/to attempt/ configure.ac <https://reviews.apache.org/r/18957/#comment70892> Instead of saving and restoring, can you just use INSTALLED_{CPP|LD}FLAGS here? INSTALLED_CPPFLAGS=$CPPFLAGS INSTALLED_LDFLAGS=$LDFLAGS Or do you need to use CPPFLAGS and LDFLAGS because AC_CHECK_* uses them? configure.ac <https://reviews.apache.org/r/18957/#comment70888> s/us/us to/ - Vinod Kone On March 26, 2014, 3:50 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18957/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 3:50 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1071 > https://issues.apache.org/jira/browse/MESOS-1071 > > > Repository: mesos-git > > > Description > ------- > > Allows preventing the use of bundled libraries in favor of preinstalled > versions, where possible. > > --disable-bundled generally switches from bundled to preinstalled libraries. > > If --disable-bundled is supplied or --with-leveldb[=DIR] or > --without-included-leveldb was given but the configuration phase could not > locate the dependency, it stops with an error. > If --disable-bundled is not supplied and no --with-leveldb[=DIR] or > --without-included-leveldb was given, the bundled library is built and used. > > --without-included-leveldb and --with-leveldb without a path are semantically > equal. > > NOTE: This review only implements this preinstalled library usage on LevelDB. > Subsequent review requests for other bundled libraries will follow as soon as > this implementation has been accepted. > > > Diffs > ----- > > 3rdparty/Makefile.am 23ff1fa > configure.ac 5404dc2 > src/Makefile.am 47d03b3 > src/python/setup.py.in 02f00ef > > Diff: https://reviews.apache.org/r/18957/diff/ > > > Testing > ------- > > ../configure > make check > > installed leveldb in custom location > ../configure --with-leveldb=/CUSTOM_LOCATION > make check > > installed leveldb in common location > ../configure --with-leveldb > make check > > installed leveldb in common location > ../configure --without-included-leveldb > make check > > installed leveldb in common location > ../configure --disable-bundled > make check > > > Thanks, > > Till Toenshoff > >
