-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18957/#review38705
-----------------------------------------------------------
Bad patch!
Reviews applied: [18957]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
zip_safe flag not set; analyzing archive contents...
log/leveldb.cpp:23:32: fatal error: leveldb/comparator.h: No such file or
directory
compilation terminated.
make[2]: *** [log/liblog_la-leveldb.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 26, 2014, 3:50 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18957/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 3:50 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1071
> https://issues.apache.org/jira/browse/MESOS-1071
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Allows preventing the use of bundled libraries in favor of preinstalled
> versions, where possible.
>
> --disable-bundled generally switches from bundled to preinstalled libraries.
>
> If --disable-bundled is supplied or --with-leveldb[=DIR] or
> --without-included-leveldb was given but the configuration phase could not
> locate the dependency, it stops with an error.
> If --disable-bundled is not supplied and no --with-leveldb[=DIR] or
> --without-included-leveldb was given, the bundled library is built and used.
>
> --without-included-leveldb and --with-leveldb without a path are semantically
> equal.
>
> NOTE: This review only implements this preinstalled library usage on LevelDB.
> Subsequent review requests for other bundled libraries will follow as soon as
> this implementation has been accepted.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 23ff1fa
> configure.ac 5404dc2
> src/Makefile.am 47d03b3
> src/python/setup.py.in 02f00ef
>
> Diff: https://reviews.apache.org/r/18957/diff/
>
>
> Testing
> -------
>
> ../configure
> make check
>
> installed leveldb in custom location
> ../configure --with-leveldb=/CUSTOM_LOCATION
> make check
>
> installed leveldb in common location
> ../configure --with-leveldb
> make check
>
> installed leveldb in common location
> ../configure --without-included-leveldb
> make check
>
> installed leveldb in common location
> ../configure --disable-bundled
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
