----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19487/#review39133 -----------------------------------------------------------
configure.ac <https://reviews.apache.org/r/19487/#comment71515> Hey Tim, sorry for the delay. JAVA_JVM_LIBRARY="$JAVA_HOME/jre/lib/server/libjvm.dylib" should do it on Mac. - Niklas Nielsen On March 20, 2014, 12:32 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19487/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 12:32 p.m.) > > > Review request for mesos, Benjamin Hindman, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-1126 > https://issues.apache.org/jira/browse/MESOS-1126 > > > Repository: mesos-git > > > Description > ------- > > The dependency on libjvm is a "hard", requiring an link and rpath. This > causes issues when shifting between jvms. The standard practice is to use > dlopen against the $JAVA_JVM_LIBRARY location. > > MESOS-1126 > + Enable dlopen for libjvm.so > + Cleanup redundant jni inclusions > > This should make MESOS-855 a non-issue. > > > Diffs > ----- > > configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a > src/Makefile.am 0775a0df293e945d41c7ba90fd1bbb503ae22f9e > src/java/jni/construct.cpp 0d0207fab6481c7e86d9b59c9e6a1aea1979cf6d > src/java/jni/convert.cpp 9f99031bb54b0720d5454ef8795145b4b92da8d4 > src/java/jni/org_apache_mesos_Log.cpp > 05489135fbd890073c58acf55312d621c7a790e7 > src/java/jni/org_apache_mesos_state_AbstractState.cpp > 476bb27dc5a17f78fc5c5beb2b2f33eec5d055a2 > src/java/jni/org_apache_mesos_state_LevelDBState.cpp > 30f63092d3839485da2a8d818febfa85c81df49f > src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp > c40e6858bc7534443e01ad189173e8cdb56b0fba > src/jvm/jvm.cpp d3dfa75db65c3360ef35dac360b6eb57009c7011 > > Diff: https://reviews.apache.org/r/19487/diff/ > > > Testing > ------- > > make check (linux only, MacOS requires input) > > > Thanks, > > Timothy St. Clair > >
