----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19487/#review40165 -----------------------------------------------------------
Just chatted with BenH. Two points: 1) Nit: Can we leave the jni.h includes in for now? 2) Forcing all JVM frameworks to provide JAVA_JVM_LIBRARY is not ideal but multiple JVM's is still a problem. Can we have a fall-back path to the jni.so/dylib found during the build and use it if JAVA_JVM_LIBRARY is not present? Or would that introduce other problems? - Niklas Nielsen On April 11, 2014, 9:34 a.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19487/ > ----------------------------------------------------------- > > (Updated April 11, 2014, 9:34 a.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Till > Toenshoff. > > > Bugs: MESOS-1126 > https://issues.apache.org/jira/browse/MESOS-1126 > > > Repository: mesos-git > > > Description > ------- > > The dependency on libjvm is a "hard", requiring an link and rpath. This > causes issues when shifting between jvms. The standard practice is to use > dlopen against the $JAVA_JVM_LIBRARY location. > > MESOS-1126 > + Enable dlopen for libjvm.so > + Cleanup redundant jni inclusions > > This should make MESOS-855 a non-issue. > > > Diffs > ----- > > configure.ac c1de6d7 > src/Makefile.am 95f133d > src/java/jni/construct.cpp 0d0207f > src/java/jni/convert.cpp 9f99031 > src/java/jni/org_apache_mesos_Log.cpp 0548913 > src/java/jni/org_apache_mesos_state_AbstractState.cpp 476bb27 > src/java/jni/org_apache_mesos_state_LevelDBState.cpp 30f6309 > src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp c40e685 > src/jvm/jvm.cpp d3dfa75 > > Diff: https://reviews.apache.org/r/19487/diff/ > > > Testing > ------- > > make check (across both Mac and Linux) > > > Thanks, > > Timothy St. Clair > >
