----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19487/#review39663 -----------------------------------------------------------
Hey Tim, I will give this a ship-it after the three style glitches and when we get input from one of the JVM framework developers (I just pinged Connor who is working on Marathon). Thanks for your patience! src/jvm/jvm.cpp <https://reviews.apache.org/r/19487/#comment72225> End with period src/jvm/jvm.cpp <https://reviews.apache.org/r/19487/#comment72226> We usually do explicit test: if (hdl == NULL) { src/jvm/jvm.cpp <https://reviews.apache.org/r/19487/#comment72224> Can you wrap this line? - Niklas Nielsen On April 1, 2014, 7:28 a.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19487/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 7:28 a.m.) > > > Review request for mesos, Benjamin Hindman, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-1126 > https://issues.apache.org/jira/browse/MESOS-1126 > > > Repository: mesos-git > > > Description > ------- > > The dependency on libjvm is a "hard", requiring an link and rpath. This > causes issues when shifting between jvms. The standard practice is to use > dlopen against the $JAVA_JVM_LIBRARY location. > > MESOS-1126 > + Enable dlopen for libjvm.so > + Cleanup redundant jni inclusions > > This should make MESOS-855 a non-issue. > > > Diffs > ----- > > configure.ac 5404dc2 > src/Makefile.am 47d03b3 > src/java/jni/construct.cpp 0d0207f > src/java/jni/convert.cpp 9f99031 > src/java/jni/org_apache_mesos_Log.cpp 0548913 > src/java/jni/org_apache_mesos_state_AbstractState.cpp 476bb27 > src/java/jni/org_apache_mesos_state_LevelDBState.cpp 30f6309 > src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp c40e685 > src/jvm/jvm.cpp d3dfa75 > > Diff: https://reviews.apache.org/r/19487/diff/ > > > Testing > ------- > > make check (across both Mac and Linux) > > > Thanks, > > Timothy St. Clair > >
