----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20106/#review39742 -----------------------------------------------------------
Great! How about a test that demonstrates the flattening for Try<T>? You can stick the test inside process_tests.cpp since we do not currently have a future_tests.cpp. 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/20106/#comment72353> Let's avoid doing Result<T> for now since supporting an implicit constructor requires template specialization for Future. Sound good? 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/20106/#comment72355> How about just calling this 'try'? 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/20106/#comment72356> Just using an 'else' would be good here. - Ben Mahler On April 7, 2014, 9:45 p.m., Ritwik Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20106/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 9:45 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1160 > https://issues.apache.org/jira/browse/MESOS-1160 > > > Repository: mesos-git > > > Description > ------- > > Support flattening from Try,Result into Future. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp 37c04c3 > > Diff: https://reviews.apache.org/r/20106/diff/ > > > Testing > ------- > > Ran all tests with suggested changes to slave.cpp > None of the tests failed. > > > Thanks, > > Ritwik Yadav > >
