> On April 7, 2014, 11:23 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/future.hpp, lines 89-90 > > <https://reviews.apache.org/r/20106/diff/1/?file=552187#file552187line89> > > > > Let's avoid doing Result<T> for now since supporting an implicit > > constructor requires template specialization for Future. > > > > Sound good?
+1! > On April 7, 2014, 11:23 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/future.hpp, line 103 > > <https://reviews.apache.org/r/20106/diff/1/?file=552187#file552187line103> > > > > How about just calling this 'try'? Since 'try' is a reserved keyword how about just 't' instead. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20106/#review39742 ----------------------------------------------------------- On April 7, 2014, 9:45 p.m., Ritwik Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20106/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 9:45 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1160 > https://issues.apache.org/jira/browse/MESOS-1160 > > > Repository: mesos-git > > > Description > ------- > > Support flattening from Try,Result into Future. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp 37c04c3 > > Diff: https://reviews.apache.org/r/20106/diff/ > > > Testing > ------- > > Ran all tests with suggested changes to slave.cpp > None of the tests failed. > > > Thanks, > > Ritwik Yadav > >
