----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20106/#review39844 -----------------------------------------------------------
Ship it! Looks good, I will make the adjustment below and get this committed for you! 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/20106/#comment72562> Would this be simpler? TEST(Future, FromTry) { Try<int> t = 1; Future<int> future = t; ASSERT_READY(future); EXPECT_EQ(1, future.get()); t = Error("error"); future = t; ASSERT_FAILED(f); } - Ben Mahler On April 8, 2014, 10:09 p.m., Ritwik Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20106/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 10:09 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1160 > https://issues.apache.org/jira/browse/MESOS-1160 > > > Repository: mesos-git > > > Description > ------- > > Support flattening from Try,Result into Future. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp 37c04c3 > 3rdparty/libprocess/src/tests/process_tests.cpp 9dae931 > > Diff: https://reviews.apache.org/r/20106/diff/ > > > Testing > ------- > > Ran all tests with suggested changes to slave.cpp > None of the tests failed. > > > Thanks, > > Ritwik Yadav > >
