----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20295/#review40233 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/20295/#comment73173> where are the header files? src/linux/routing/filter/action.hpp <https://reviews.apache.org/r/20295/#comment73176> src/linux/routing/filter/icmp.hpp <https://reviews.apache.org/r/20295/#comment73175> s/dstIP/destinationIP/ src/linux/routing/filter/icmp.hpp <https://reviews.apache.org/r/20295/#comment73177> What happens if two Classifiers have overlapping set of links? The first match wins? src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/20295/#comment73178> A comment on what 'pack' does would be nice. src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/20295/#comment73181> s/valueProtocol/protocol/ src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/20295/#comment73182> s/valueProtocolMask/mask/ src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/20295/#comment73179> what is this doing? comment? src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/20295/#comment73180> what is this doing? comment? src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/20295/#comment73185> what is this doing? comment?. src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/20295/#comment73183> s/valueProtocol/protocol/ src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/20295/#comment73184> s/valueDstIP/destinationIP/ src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/20295/#comment73186> s/set/sets/ src/linux/routing/filter/icmp.cpp <https://reviews.apache.org/r/20295/#comment73187> What is the need for this 'internal' indirection? src/linux/routing/filter/priority.hpp <https://reviews.apache.org/r/20295/#comment73188> should these hex values be replaced by static const variables declared below in private? - Vinod Kone On April 13, 2014, 11:45 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20295/ > ----------------------------------------------------------- > > (Updated April 13, 2014, 11:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > This is Part 2 of the linux routing library. > > > Diffs > ----- > > src/Makefile.am 560b4c7 > src/linux/routing/filter/action.hpp PRE-CREATION > src/linux/routing/filter/icmp.hpp PRE-CREATION > src/linux/routing/filter/icmp.cpp PRE-CREATION > src/linux/routing/filter/internal.hpp PRE-CREATION > src/linux/routing/filter/priority.hpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20295/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
