> On April 14, 2014, 3:37 a.m., Vinod Kone wrote: > > src/linux/routing/filter/icmp.hpp, line 69 > > <https://reviews.apache.org/r/20295/diff/1/?file=555698#file555698line69> > > > > What happens if two Classifiers have overlapping set of links? The > > first match wins?
Each filter consists of a "classifier" and an "action". The "action" of a filter will be taken if a packet satisfies the conditions specified by the "classifier". If a packet satisfies multiple classifiers, the priority decides the preference order. > On April 14, 2014, 3:37 a.m., Vinod Kone wrote: > > src/linux/routing/filter/priority.hpp, lines 51-53 > > <https://reviews.apache.org/r/20295/diff/1/?file=555701#file555701line51> > > > > should these hex values be replaced by static const variables declared > > below in private? The static const variables declared below are "type" part of the priority. The number here are "value" part of the priority (see comments above). BTW: Previously, I call them "major" and "minor" part of the priority. However, seems that some linux header defines major/minor as a macro, causing some compilation issue. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20295/#review40233 ----------------------------------------------------------- On April 13, 2014, 11:45 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20295/ > ----------------------------------------------------------- > > (Updated April 13, 2014, 11:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > This is Part 2 of the linux routing library. > > > Diffs > ----- > > src/Makefile.am 560b4c7 > src/linux/routing/filter/action.hpp PRE-CREATION > src/linux/routing/filter/icmp.hpp PRE-CREATION > src/linux/routing/filter/icmp.cpp PRE-CREATION > src/linux/routing/filter/internal.hpp PRE-CREATION > src/linux/routing/filter/priority.hpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20295/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
