-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20295/
-----------------------------------------------------------

(Updated April 18, 2014, 7:36 p.m.)


Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, 
and Cong Wang.


Changes
-------

Review comments. I changed a few internal APIs:

1) made priority setting more explicit and killed hard coded internal priority 
dependencies
2) left interfaces for adding more actions to a filter in the future (left a 
TODO)
3) allowed users to get actions attached to a filter if libnl supports that in 
the future


Repository: mesos-git


Description
-------

This is Part 2 of the linux routing library.


Diffs (updated)
-----

  src/Makefile.am 9e715bf 
  src/linux/routing/filter/action.hpp PRE-CREATION 
  src/linux/routing/filter/icmp.hpp PRE-CREATION 
  src/linux/routing/filter/icmp.cpp PRE-CREATION 
  src/linux/routing/filter/internal.hpp PRE-CREATION 
  src/linux/routing/filter/priority.hpp PRE-CREATION 
  src/tests/routing_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/20295/diff/


Testing
-------

make check
sudo make check


Thanks,

Jie Yu

Reply via email to