----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/#review40265 -----------------------------------------------------------
3rdparty/libprocess/include/process/metrics/counter.hpp <https://reviews.apache.org/r/20015/#comment73223> We should add a comment to these constructors that explains what the window is and how it's associated with the time series that is maintained and I'd prefer s/historyWindow/window/. 3rdparty/libprocess/include/process/metrics/counter.hpp <https://reviews.apache.org/r/20015/#comment73224> PLEASE PUT '{' ON NEW LINES! 3rdparty/libprocess/include/process/metrics/gauge.hpp <https://reviews.apache.org/r/20015/#comment73225> Why do we not want to collect a time series for gauge? 3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/20015/#comment73227> s/historyWindow/window/ 3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/20015/#comment73226> The code base tries to be consistent about putting NULL on the other side of the conditional, let's do that here too please. 3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/20015/#comment73228> Ah, now I see why you chose 'historyWindow', why not s/history/timeseries/? 3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/20015/#comment73229> Let's use s/shared/memory/ please and include <stout/memory.hpp> (see https://reviews.apache.org/r/20305). 3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/20015/#comment73232> Not two spaces. 3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/20015/#comment73231> Not two spaces. - Benjamin Hindman On April 10, 2014, 10:21 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20015/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 10:21 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/counter.hpp > f4774ada4dbe3fa18b5a8b204f97f59ca015b3c1 > 3rdparty/libprocess/include/process/metrics/gauge.hpp > 4f5c1086ac3553319431283165c5451df1a0ee3f > 3rdparty/libprocess/include/process/metrics/metric.hpp > ea64f699fd9ec38745d84c7523133709827f96db > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 0cc9f4bcbbb03ac3a9a2d57f64b944443fcb94bb > > Diff: https://reviews.apache.org/r/20015/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Dominic Hamon > >
