> On April 14, 2014, 9:58 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/metrics/counter.hpp, line 19 > > <https://reviews.apache.org/r/20015/diff/5/?file=554792#file554792line19> > > > > PLEASE PUT '{' ON NEW LINES!
i remembered everywhere else :P > On April 14, 2014, 9:58 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/metrics/gauge.hpp, line 23 > > <https://reviews.apache.org/r/20015/diff/5/?file=554793#file554793line23> > > > > Why do we not want to collect a time series for gauge? gauge will be pull-based so the time series will be populated by that system and the window option will be exposed when polling is implemented. We could also maintain history and push every time the gauge is accessed, but that's a little unintuitive. > On April 14, 2014, 9:58 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/metrics/metric.hpp, line 55 > > <https://reviews.apache.org/r/20015/diff/5/?file=554794#file554794line55> > > > > Ah, now I see why you chose 'historyWindow', why not > > s/history/timeseries/? well that's just the type. maybe there'll be a second timeseries at some point that is something else ;) > On April 14, 2014, 9:58 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/metrics/metric.hpp, lines 72-73 > > <https://reviews.apache.org/r/20015/diff/5/?file=554794#file554794line72> > > > > Not two spaces. with cppstyle now being run more often, two spaces is expected. it's also what we have in our style guide. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/#review40265 ----------------------------------------------------------- On April 14, 2014, 1:29 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20015/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 1:29 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/counter.hpp > f4774ada4dbe3fa18b5a8b204f97f59ca015b3c1 > 3rdparty/libprocess/include/process/metrics/gauge.hpp > 4f5c1086ac3553319431283165c5451df1a0ee3f > 3rdparty/libprocess/include/process/metrics/metric.hpp > ea64f699fd9ec38745d84c7523133709827f96db > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 0cc9f4bcbbb03ac3a9a2d57f64b944443fcb94bb > > Diff: https://reviews.apache.org/r/20015/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Dominic Hamon > >
