----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20302/#review40492 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/20302/#comment73524> Can you also update master to send some meaningful message(s) when it sends a shutdown (e.g. "health check timeout)" src/slave/slave.cpp <https://reviews.apache.org/r/20302/#comment73523> if message is empty it would be odd to see a period at the end. how about LOG(INFO) << "Slave asked to shutdown by " << from << (message.empty() ? "" : "because '" + message + "'"); src/tests/cluster.hpp <https://reviews.apache.org/r/20302/#comment73522> s/std::string()/""/ and put it back on one line. - Vinod Kone On April 14, 2014, 7:04 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20302/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 7:04 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Add a message string to the slave ShutdownMessage. To be used in slave > authentication, and anything else that likes shutdown messages. > > > Diffs > ----- > > src/messages/messages.proto bba17a9 > src/slave/slave.hpp 08f6005 > src/slave/slave.cpp cddb241 > src/tests/cluster.hpp 8479fe3 > > Diff: https://reviews.apache.org/r/20302/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Adam B > >
