----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20302/#review40622 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/20302/#comment73691> s/was not admitted/attempted to register but got duplicate slave id + stringify(slaveInfo.id())/ src/master/master.cpp <https://reviews.apache.org/r/20302/#comment73690> s/unregistered/attempted to re-register after deactivation/ src/master/master.cpp <https://reviews.apache.org/r/20302/#comment73693> s/could not be readmitted/attempted to re-register with unknown slave id + stringify(slaveInfo.id())/ src/master/master.cpp <https://reviews.apache.org/r/20302/#comment73695> s/unregistered/status update from unknown slave/ src/master/master.cpp <https://reviews.apache.org/r/20302/#comment73696> s/unregistered/executor exited message from unknown slave/ src/master/master.cpp <https://reviews.apache.org/r/20302/#comment73697> it seems a bit weird for this method to know why the slave is being shutdown (i.e., health check timeout). how about having this method take the message as a parameter and have the slave observer set the message? - Vinod Kone On April 17, 2014, 1:17 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20302/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 1:17 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Add a message string to the slave ShutdownMessage. To be used in slave > authentication, and anything else that likes shutdown messages. > > > Diffs > ----- > > src/master/master.cpp 3c3c989 > src/messages/messages.proto bba17a9 > src/slave/slave.hpp 1e98795 > src/slave/slave.cpp 19c5f0d > src/tests/cluster.hpp 8479fe3 > > Diff: https://reviews.apache.org/r/20302/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Adam B > >
