> On April 15, 2014, 8:34 p.m., Vinod Kone wrote: > > src/tests/cluster.hpp, line 508 > > <https://reviews.apache.org/r/20302/diff/2/?file=556292#file556292line508> > > > > s/std::string()/""/ > > > > and put it back on one line.
Funny, I had "" in my first patch. I also prefer "", so I'm going with that unless Dominic can convince me otherwise. And even with "", it comes out to 81 chars, so I'm still wrapping it. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20302/#review40492 ----------------------------------------------------------- On April 14, 2014, 12:04 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20302/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 12:04 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Add a message string to the slave ShutdownMessage. To be used in slave > authentication, and anything else that likes shutdown messages. > > > Diffs > ----- > > src/messages/messages.proto bba17a9 > src/slave/slave.hpp 08f6005 > src/slave/slave.cpp cddb241 > src/tests/cluster.hpp 8479fe3 > > Diff: https://reviews.apache.org/r/20302/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Adam B > >
