----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20823/#review41716 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/20823/#comment75280> An alternative is using MESOS_HAS_PYTHON to guard the code that needs python, similar to what we did for zookeeper tests. If you introduce more tests in external_containerizer_test.cpp and some of them does not need python, then the above solution is better. - Jie Yu On April 29, 2014, 1:39 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20823/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 1:39 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Currently ExternalContainerizerTest.Launch relies upon a Python script which > in turn relies upon the Mesos Python egg being available. When Python is > disabled (--disable-python) during the configuration phase, the Mesos Python > egg is not being built, hence the Python script (test_containerizer.py) can > not use it and the test fails. > > This patch excludes ExternalContainerizerTest.Launch from the test-suite when > Python has been disabled. > > > Diffs > ----- > > src/Makefile.am cd06125 > > Diff: https://reviews.apache.org/r/20823/diff/ > > > Testing > ------- > > ../configure --disable-python > make check > > ../configure > make check > > > Thanks, > > Till Toenshoff > >
