Committed. Please mask the patch as submitted. Thanks Till! - Jie
On Tue, Apr 29, 2014 at 12:17 PM, Jie Yu <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20823/#review41761 > ----------------------------------------------------------- > > Ship it! > > > Ship It! > > - Jie Yu > > > On April 29, 2014, 5:59 p.m., Till Toenshoff wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/20823/ > > ----------------------------------------------------------- > > > > (Updated April 29, 2014, 5:59 p.m.) > > > > > > Review request for mesos and Jie Yu. > > > > > > Repository: mesos-git > > > > > > Description > > ------- > > > > Currently ExternalContainerizerTest.Launch relies upon a Python script > which in turn relies upon the Mesos Python egg being available. When Python > is disabled (--disable-python) during the configuration phase, the Mesos > Python egg is not being built, hence the Python script > (test_containerizer.py) can not use it and the test fails. > > > > This patch excludes ExternalContainerizerTest.Launch from the test-suite > when Python has been disabled. > > > > > > Diffs > > ----- > > > > src/tests/external_containerizer_test.cpp 6f7b13e > > > > Diff: https://reviews.apache.org/r/20823/diff/ > > > > > > Testing > > ------- > > > > ../configure --disable-python > > make check > > > > ../configure > > make check > > > > > > Thanks, > > > > Till Toenshoff > > > > > >
