> On April 29, 2014, 4:25 p.m., Jie Yu wrote: > > src/Makefile.am, line 921 > > <https://reviews.apache.org/r/20823/diff/1/?file=570002#file570002line921> > > > > An alternative is using MESOS_HAS_PYTHON to guard the code that needs > > python, similar to what we did for zookeeper tests. > > > > If you introduce more tests in external_containerizer_test.cpp and some > > of them does not need python, then the above solution is better. > > > >
That is true - both options appear to have their advantages; When looking only at the status-quo, excluding it via Makefile.am appears to be more efficient. When looking at possible test-extensions that do not need that python egg, using the define-guard certainly has more flexibility. Now lets see what we envision as a roadmap for the tests; We want to cover the ExternalContainerizer by reusing / extending general Containerizer tests instead of having specific EC tests. It seems that down the road, we might actually get to a scenario that matches your solution, hence I will update this RR. Thanks! - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20823/#review41716 ----------------------------------------------------------- On April 29, 2014, 1:39 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20823/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 1:39 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Currently ExternalContainerizerTest.Launch relies upon a Python script which > in turn relies upon the Mesos Python egg being available. When Python is > disabled (--disable-python) during the configuration phase, the Mesos Python > egg is not being built, hence the Python script (test_containerizer.py) can > not use it and the test fails. > > This patch excludes ExternalContainerizerTest.Launch from the test-suite when > Python has been disabled. > > > Diffs > ----- > > src/Makefile.am cd06125 > > Diff: https://reviews.apache.org/r/20823/diff/ > > > Testing > ------- > > ../configure --disable-python > make check > > ../configure > make check > > > Thanks, > > Till Toenshoff > >
