> On May 1, 2014, 5:46 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 659 > > <https://reviews.apache.org/r/20955/diff/1/?file=572679#file572679line659> > > > > Why doesn't this return a Try? > > Ben Mahler wrote: > It's an existing method, so I don't think he wants to go and change all > the callers :)
Not in this review at least ;-) - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20955/#review41988 ----------------------------------------------------------- On May 2, 2014, 3:02 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20955/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 3:02 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > These will be used for a later review where I need to pass uid and gid to a > forked child which will use the async signal safe ::setgid and ::setuid. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 38756617ead1b6651e44ab989871ea3e68d130df > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 94eb256d24bc001660d63bd91b608988205a3d09 > > Diff: https://reviews.apache.org/r/20955/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
