> On May 16, 2014, 11:54 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 648 > > <https://reviews.apache.org/r/20955/diff/3/?file=583729#file583729line648> > > > > How are you able to allocate on the stack when bufsize is determined at > > runtime via sysconf? Did this compile? > > > > Looks like this buffer needs to be on the heap.
Oh, it does compile. New compilers support that. Not sure about old compilers:) - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20955/#review43288 ----------------------------------------------------------- On May 16, 2014, 10:08 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20955/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 10:08 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > These will be used for a later review where I need to pass uid and gid to a > forked child which will use the async signal safe ::setgid and ::setuid. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 38756617ead1b6651e44ab989871ea3e68d130df > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 3e511355e1faf7160442799e1e08d59b6f3b2f37 > > Diff: https://reviews.apache.org/r/20955/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
