----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20955/#review43528 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20955/#comment77729> What if gid.isNone() is true? What error message will you print? 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20955/#comment77730> Ditto. - Jie Yu On May 19, 2014, 10:58 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20955/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 10:58 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > These will be used for a later review where I need to pass uid and gid to a > forked child which will use the async signal safe ::setgid and ::setuid. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 38756617ead1b6651e44ab989871ea3e68d130df > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 3e511355e1faf7160442799e1e08d59b6f3b2f37 > > Diff: https://reviews.apache.org/r/20955/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
