> On May 8, 2014, 11:13 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 3087-3107 > > <https://reviews.apache.org/r/19499/diff/9/?file=573410#file573410line3087> > > > > Why are these separate from the other Gauge methods, can they go in the > > header for now? We could move them all to slave/metrics.cpp in the future.
as with the master, these require Framework and Executor to be complete types. We can either move them to the header and change the order of class definitions in the header, or have them here. Here is less disruptive. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19499/#review42520 ----------------------------------------------------------- On May 8, 2014, 11:47 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19499/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 11:47 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1133 > https://issues.apache.org/jira/browse/MESOS-1133 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5 > src/slave/slave.cpp 2a48266510a600349692780ea39cc98c3e12da30 > src/tests/slave_tests.cpp 09824550101577f8c9cf65c18e4980b74494a7d7 > > Diff: https://reviews.apache.org/r/19499/diff/ > > > Testing > ------- > > make check. ran locally and compared stats.json endpoint to /metrics/snapshot > endpoint. > > > Thanks, > > Dominic Hamon > >
