----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21233/#review42580 -----------------------------------------------------------
Hey Ben, curious how this behaves when no splicing occurs: what happens when the pipes fill up in the subprocess? src/slave/fetcher.hpp <https://reviews.apache.org/r/21233/#comment76389> This is only exposed for testing? Maybe this would be a good place to comment on considering JSON in the environment (we'd need to confirm that our JSON encoding only uses the portable character set). src/slave/fetcher.hpp <https://reviews.apache.org/r/21233/#comment76398> When 'stdout' and 'stderr' are not provided, won't we potentially fill up the Subprocess' pipes, blocking the write()s in the subprocess? Should we be splicing to /dev/null in that case? Perhaps this is a weakness of the Subprocess abstraction currently? - Ben Mahler On May 8, 2014, 11:09 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21233/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 11:09 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, Ian Downes, Tom Arnfeld, > and Vinod Kone. > > > Bugs: MESOS-1316 > https://issues.apache.org/jira/browse/MESOS-1316 > > > Repository: mesos-git > > > Description > ------- > > To test the mesos-fetcher (and the setting of the environment) more cleanly I > did some refactoring into a 'fetcher' namespace. > > > Diffs > ----- > > src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029 > src/launcher/fetcher.cpp 8c9e20da8f39eb5e90403a5093cbea7fb2680468 > src/slave/containerizer/mesos_containerizer.cpp > 2a4816ec34f2298b71e8591c1e92d77f94ef4cb3 > src/slave/fetcher.hpp PRE-CREATION > src/tests/containerizer_tests.cpp 9d20853bcc1965adc2d9ea41044b5613cd992f11 > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21233/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
