> On May 9, 2014, 2 p.m., Ben Mahler wrote: > > Sending to /dev/null when the Options are none sounds good to me.
While this is all very nice, shipping it would further delay MESOS-336. It would be easier to get that done first and refactor afterwards, IMHO. - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21233/#review42604 ----------------------------------------------------------- On May 8, 2014, 4:09 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21233/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 4:09 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, Ian Downes, Tom Arnfeld, > and Vinod Kone. > > > Bugs: MESOS-1316 > https://issues.apache.org/jira/browse/MESOS-1316 > > > Repository: mesos-git > > > Description > ------- > > To test the mesos-fetcher (and the setting of the environment) more cleanly I > did some refactoring into a 'fetcher' namespace. > > > Diffs > ----- > > src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029 > src/launcher/fetcher.cpp 8c9e20da8f39eb5e90403a5093cbea7fb2680468 > src/slave/containerizer/mesos_containerizer.cpp > 2a4816ec34f2298b71e8591c1e92d77f94ef4cb3 > src/slave/fetcher.hpp PRE-CREATION > src/tests/containerizer_tests.cpp 9d20853bcc1965adc2d9ea41044b5613cd992f11 > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21233/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
