----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21233/#review44197 -----------------------------------------------------------
Can you rebase please :-) - Ian Downes On May 28, 2014, 4:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21233/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 4:01 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, Ian Downes, Tom Arnfeld, > and Vinod Kone. > > > Bugs: MESOS-1316 > https://issues.apache.org/jira/browse/MESOS-1316 > > > Repository: mesos-git > > > Description > ------- > > To test the mesos-fetcher (and the setting of the environment) more cleanly I > did some refactoring into a 'fetcher' namespace. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 8f32a66c6ad593ff3bd508c7e687aaff22933324 > 3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp > 110cb49fe0a1306cfa8eeee1ffe7b542f75d69b7 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > 112dcb1c51315e04267edba2e1e2c86212aeecd6 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp > 120946909cd19653ae5f71d401b5c9ea6d8228cd > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 72f3e70ccc189d0a7dd613ccaf79537d3587c49c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/execenv.hpp > 1dd6c90f35a5c060d2455fdf399b1fff44ba841b > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > 3b60ff824bada441cd657e10ca01762085a6d099 > 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp > 4fe3f22915cbc11df3f4424e3bd8acaf45509e19 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 1a6ce0b9a70c0334946e456696b814961e5b4018 > 3rdparty/libprocess/3rdparty/stout/tests/utils.hpp > 070bc6e5375d85d6e055e2d526fcf026a3a3fc5c > 3rdparty/libprocess/Makefile.am b687068b543947ab05482f5f34d982e017323007 > 3rdparty/libprocess/include/process/http.hpp > 6358e331ae1256b19d52a6803875d2b64d75eb69 > 3rdparty/libprocess/include/process/metrics/timer.hpp > 01cb290d6b93e14f711b3bb5840c9910e54f2812 > 3rdparty/libprocess/include/process/owned.hpp > ad6c734c9b8df23b6a331c5009a2c1219a25de6e > 3rdparty/libprocess/include/process/system.hpp > 366a4b2bb95065e9a2f45c5124d86aad997d854f > 3rdparty/libprocess/src/subprocess.cpp > 9f8f37f5362aaa85f6b2f448d3f4d64a1c95f020 > 3rdparty/libprocess/src/tests/http_tests.cpp > a1c3685c88d268c7ecdc2dad22608198dc0b295d > 3rdparty/libprocess/src/tests/metrics_tests.cpp > a822bc78de92ae95fd463881ec0bba7fdb627bc6 > 3rdparty/libprocess/src/tests/owned_tests.cpp > 50025d98d3abd73f34b2d0052970776c37870ef8 > 3rdparty/libprocess/src/tests/system_tests.cpp > e07314f901fb5ed597efcc899e5480dcd6c4aade > CHANGELOG 9d87e0af05301177d574a6b122fbec29de2243d2 > bin/mesos-local-flags.sh.in ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 > configure.ac 1ebd19623c837dec205136a8aa0b1497b8dee6ce > docs/configuration.md fb92cfaf185ee5daecff54038050bb5894ae92e4 > docs/getting-started.md 446396d043b8aa7dadc92fe7e17be69f3d471084 > docs/high-availability.md b2a62c41a19f6346c53afae468f3241687669313 > docs/mesos-developers-guide.md 036a6fd336c1173be73393e5ee62dba208378518 > docs/powered-by-mesos.md 3e094fd287a822ed266ce96542a700675f0f5e8c > include/mesos/containerizer/containerizer.proto > 29df785ec6f86b6371c8e2a23871be2c7284e5cd > include/mesos/mesos.proto 82388e1ed5ee36aaf7fc31d7a59aa0923ee9ab46 > src/Makefile.am ffde59be8683dd40cc5bc7cb88cd88c5bc91cf96 > src/authorizer/authorizer.hpp b0d1eae7e9e64a2ded6532de1f1bf5d2db70ecd7 > src/common/resources.cpp d39001bdabd14924c9ee3697ede81dd242768768 > src/credentials/credentials.hpp 98b908846657d58a6f2f55121a17630df2508788 > src/examples/python/test_containerizer.py > c65d891539bcee775741626596997afe8471c930 > src/java/src/org/apache/mesos/state/ZooKeeperState.java > cb0eba00bbc09d4787d05d87908312caba79486f > src/launcher/executor.cpp 3d55d9346921b687937348da72ef5cd5226d09c3 > src/launcher/fetcher.cpp c4425ebaf339a99b76e4e48628d2ac4761d2c408 > src/linux/routing/filter/action.hpp > 8cc65940686bf6ec4e46e0b49075ad5871c0ab3a > src/linux/routing/filter/arp.hpp fa0ea6f93218fb3bee9f435f0268022d5edc5e11 > src/linux/routing/filter/arp.cpp c18aebb8eeae9ba537cbfcdb994db233d5e5b322 > src/linux/routing/filter/filter.hpp > 40e21db14073d9c2749e42029a3d13e6d0a7f2a3 > src/linux/routing/filter/icmp.hpp dc075a7c2643d85c81355de8ce8fbf43addbd056 > src/linux/routing/filter/icmp.cpp 8e6f01344f4a7a2056a6051f22eb17b3b75b3b54 > src/linux/routing/filter/internal.hpp > cd3279af33a769cb33ebae31ab798c392f851d91 > src/linux/routing/filter/ip.hpp 8f46ee5aa42d73bc3e7d97f72802a918fbe9e4a1 > src/linux/routing/filter/ip.cpp 86dbf35a5e661d4a873b755cbaba4e06d001026d > src/linux/routing/filter/priority.hpp > 699ad17c5359cd9268f60b59ac5cee34b5b2f67b > src/linux/routing/internal.hpp dca0dc55576932e1f68540388cbd0869079dace7 > src/linux/routing/link/internal.hpp > 0d46e9a6901c79514bd83c27a89c83407f356578 > src/linux/routing/link/link.hpp 4264a1ea979bf0d9624adf99174c8ef6a7960d16 > src/linux/routing/link/link.cpp ebcd1190734b63b095d369850bea83810b9e55b5 > src/linux/routing/queueing/handle.hpp > 2725d0794ca29ad5dc1b0148d0f68b90ce8b8369 > src/linux/routing/queueing/handle.cpp > cd34fc41a0b4233520a606cb439b286777c6a995 > src/linux/routing/queueing/ingress.hpp > b323a7f6daed828327d6d9e9740df81582e0ba2b > src/linux/routing/queueing/ingress.cpp > e696950a39fb9da3dfa614c71a02e85e0e5096f1 > src/linux/routing/queueing/internal.hpp > 4d8bd55096df9192e5656c899c537ac3bd45b7d9 > src/linux/routing/route.hpp 435b98190044500cc6fa84c04ad34a9a911c70d9 > src/linux/routing/route.cpp 234027e90a85dc308046aa7c86fd7e49a8738b86 > src/linux/routing/utils.hpp a3d914ae7844fdac65c06020b34a63333b0724bc > src/linux/routing/utils.cpp 80b62d01bc2a89842407ea4dc836f9657692267c > src/log/leveldb.cpp 2967a1f7c6ff35c1280299c3d73aaa951ab89273 > src/master/flags.hpp e89022747fdda9dbe2124f4512931b7c1a32cfae > src/master/http.cpp b565dc6c36a9e9e09b6b273e8d03e3d2c0c4438c > src/master/master.hpp 4c21d9e83cd647d24ec92260f4d3d66e60c5df25 > src/master/master.cpp efb4de1216df3fccf3706a5c615960ec00434440 > src/master/registrar.cpp 5c74471d5f61338080ad68cd9a7a6d6346682573 > src/sasl/authenticator.hpp 365db5f040cdaec9d7691aa6984be3d929b8692b > src/sched/sched.cpp be23e012fba99363b72b749b110f12ce3c902014 > src/slave/constants.hpp ace459071d7b1906fe8665878a60ae9edf7d0022 > src/slave/constants.cpp 51f65bb8b938690084460c0160fdc563657f3678 > src/slave/containerizer/external_containerizer.hpp > 7e5474ced38da4b1f45a2a7e47685bb4a0ff6c64 > src/slave/containerizer/external_containerizer.cpp > b39c8455a8a28eddc0febc80282930f2d36bda19 > src/slave/containerizer/linux_launcher.hpp > 60b401f26d369cafec46e03be61bd1df001c3544 > src/slave/containerizer/mesos_containerizer.cpp > d01d4437e9553664726fe25d6176a137cf877b28 > src/slave/fetcher.hpp PRE-CREATION > src/slave/fetcher.cpp PRE-CREATION > src/slave/flags.hpp 15e5b64fd24a9381074b4833a0403314e1f404bc > src/slave/slave.hpp 34687e555e6ba07863c45840aa6d07717388cf62 > src/slave/slave.cpp 7fbedb1e4ff768d42de75d20c86a6c927f65b86b > src/tests/allocator_tests.cpp 79ea09c8d05aa3ac3c035ea3964858bff601e213 > src/tests/authentication_tests.cpp 5cf2da4602edbf7c168351d5f581aca10591d5d0 > src/tests/authorization_tests.cpp 611f3713c0bf4dee631a935f08c9edf2776ab3ad > src/tests/cluster.hpp f4cc9a62cd0ca86cd87987d963abd951a377ddd1 > src/tests/containerizer.hpp 9325864691fb45d98f006f410c25f8fbd27b76bb > src/tests/containerizer.cpp 3f11d352522e7a1e9c8ca74d033c25c4ec7a6d23 > src/tests/containerizer_tests.cpp 8ea7974ef74582afa9f670ccccb8139bad993cbc > src/tests/environment.cpp 3e105084d5fcec30245f6d1a35a7dcc4c220b954 > src/tests/fault_tolerance_tests.cpp > 3f2639347c7fde1b1b8e3c976e493b5fa2c3ade2 > src/tests/fetcher_tests.cpp PRE-CREATION > src/tests/gc_tests.cpp df15746d1eea45c7da711144c51f74d0a82e0fca > src/tests/isolator.hpp 89df4c4959c680354b002fa12e3a270a358087af > src/tests/master_contender_detector_tests.cpp > 231648d3c564f9a38937b844459c08f0fdd66a92 > src/tests/master_tests.cpp b0ff6277120636fe9045b12443e5e2dd29a3df1b > src/tests/mesos.hpp 1b0f358cb008bc2cb81f5e72029d564921bcb379 > src/tests/mesos.cpp 3065ae30bceb8b258d071110c0360f701ff48b64 > src/tests/reconciliation_tests.cpp 677d18e1a4e1683809d21eb96bab48d6e3868207 > src/tests/resource_offers_tests.cpp > 653f72d3af41de21b05d913377cb4aa27f7fe823 > src/tests/routing_tests.cpp 0e8f61a569a908d310e5711af853dc8700efcac8 > src/tests/sasl_tests.cpp 59e1c95370879d4b006bfd80f16ce2a1f54a61df > src/tests/scheduler_tests.cpp 721d1cf74d980649f43dfb9e8778036f1b7780a6 > src/tests/slave_recovery_tests.cpp 44ffac40b9edc9940f17b5fbe1848d56cf53b69b > src/tests/slave_tests.cpp 80fe3cfd66c536fa02f5c42cf5fe7d8bdd4251ab > src/tests/status_update_manager_tests.cpp > c753921194a3ae449feff0b20dfc058b6e086528 > src/tests/utils.hpp 5c86fd47315ceb236c60e2baece9242da580587f > src/usage/usage.hpp 5a76746d17cc70c2a35449f80cdd062ebdffe689 > src/usage/usage.cpp 29014d1763fa122096dae6065f68b28abade9401 > src/webui/master/static/home.html ce8ca192235c224715c01fef0b8ddb187dc0a827 > src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 > src/webui/master/static/js/controllers.js > 41a70a80442501a2bf7b217939dbe504662941d2 > src/zookeeper/zookeeper.cpp 9c0c038c7f7932688fb001c7ea88dc4088d633c9 > support/hooks/pre-commit f6910f852a51d64a3441f9c23e70cafc6f7de741 > support/mesos-style.py fd12be9ad1647e658bca45f181f9aa9da1a15084 > support/post-reviews.py 6814b0be5f53504b7a7094633bec718bb165d3e9 > support/verify-reviews.py a84f9ce6d2c4b40edf0539ec3b7cefadc3c29ba3 > > Diff: https://reviews.apache.org/r/21233/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
