> On May 9, 2014, 5:35 p.m., Ben Mahler wrote: > > src/master/master.hpp, lines 566-569 > > <https://reviews.apache.org/r/19504/diff/11/?file=577350#file577350line566> > > > > 'slaves.deactivated' is actually the _removed_ slaves! > > > > We'll want 'active_slaves' to count those slaves in 'slaves.activated' > > that are connected, and 'inactive_slaves' to count those slaves in > > 'slaves.activated' that are disconnected (no offers being sent for them).
in Slave::addOffer we don't check disconnected - should we? - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19504/#review42595 ----------------------------------------------------------- On May 12, 2014, 10:21 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19504/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 10:21 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1132 and MESOS-1332 > https://issues.apache.org/jira/browse/MESOS-1132 > https://issues.apache.org/jira/browse/MESOS-1332 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/http.cpp f54c841d003d7a4d2eda5e93405afa358707f4e0 > src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e > src/master/master.cpp d851a7291acce950ea9391ddfb8813a432aeda34 > src/tests/master_tests.cpp 30ea7ffad4eb0ad011942d91cbf61284b031a80e > > Diff: https://reviews.apache.org/r/19504/diff/ > > > Testing > ------- > > ran locally and checked /metrics/snapshot vs master/stats.json > > make check > > > Thanks, > > Dominic Hamon > >
