----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19504/#review42521 -----------------------------------------------------------
Let's add to the MasterTest.MetricsInStatsEndpoint to make sure we've converted everything! A TODO for master/metrics.cpp might be nice as well. src/master/http.cpp <https://reviews.apache.org/r/19504/#comment76312> Can you link up the review for this TODO so that it depends on this one? src/master/master.cpp <https://reviews.apache.org/r/19504/#comment76311> Can this go up with the other gauge methods? - Ben Mahler On May 5, 2014, 5:42 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19504/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 5:42 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1132 > https://issues.apache.org/jira/browse/MESOS-1132 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/http.cpp f54c841d003d7a4d2eda5e93405afa358707f4e0 > src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e > src/master/master.cpp c79fdafde6b08d74e6fea71afa79aded41b3a9ab > > Diff: https://reviews.apache.org/r/19504/diff/ > > > Testing > ------- > > ran locally and checked /metrics/snapshot vs master/stats.json > > make check > > > Thanks, > > Dominic Hamon > >
