> On May 8, 2014, 11:38 a.m., Ben Mahler wrote: > > src/master/http.cpp, line 380 > > <https://reviews.apache.org/r/19504/diff/9/?file=574761#file574761line380> > > > > Can you link up the review for this TODO so that it depends on this one?
that review depends on the defer being removed from Gauge (review 20995) so i can't have it depend on this too. > On May 8, 2014, 11:38 a.m., Ben Mahler wrote: > > src/master/master.cpp, lines 3660-3670 > > <https://reviews.apache.org/r/19504/diff/9/?file=574763#file574763line3660> > > > > Can this go up with the other gauge methods? it requires Framework to be a complete type so yes, if we move the definition of Framework above Master in the header. This felt more disruptive than just having this in the source file. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19504/#review42521 ----------------------------------------------------------- On May 8, 2014, 12:01 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19504/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 12:01 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1132 > https://issues.apache.org/jira/browse/MESOS-1132 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/http.cpp f54c841d003d7a4d2eda5e93405afa358707f4e0 > src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e > src/master/master.cpp c79fdafde6b08d74e6fea71afa79aded41b3a9ab > src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42 > > Diff: https://reviews.apache.org/r/19504/diff/ > > > Testing > ------- > > ran locally and checked /metrics/snapshot vs master/stats.json > > make check > > > Thanks, > > Dominic Hamon > >
