----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21276/#review42735 -----------------------------------------------------------
src/slave/slave.hpp <https://reviews.apache.org/r/21276/#comment76597> These terminal task state Gauges are only capturing the information contained within the slave's cache of terminated executors / tasks. This can be unfortunate as these metrics will only reflect our cached information, rather than the total number of tasks that reached a terminal state. For example, consider a slave that ran 50,000 tasks to TASK_FINISHED through a single executor/framework. This patch will expose "tasks_finished" as 300 (MAX_COMPLETED_TASKS_PER_EXECUTOR), rather than as 50,000. Given that we don't store infinite task / executor / framework history in the slave, can we change these terminal Gauges to Counters? - Ben Mahler On May 9, 2014, 6:46 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21276/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 6:46 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1332 > https://issues.apache.org/jira/browse/MESOS-1332 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/slave/slave.hpp ed20dca70cfbbd11dcdb35a074dc1777721f6ca5 > src/slave/slave.cpp ba4bd731bc21cdf853c3d390296252ad4d0901cb > > Diff: https://reviews.apache.org/r/21276/diff/ > > > Testing > ------- > > make check > > ran locally and manually verified > > > Thanks, > > Dominic Hamon > >
