----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21276/#review42843 -----------------------------------------------------------
src/slave/slave.hpp <https://reviews.apache.org/r/21276/#comment76761> maybe a new line here to differentiate gauges and counters? src/slave/slave.cpp <https://reviews.apache.org/r/21276/#comment76759> kill white space. src/slave/slave.cpp <https://reviews.apache.org/r/21276/#comment76762> Move this to terminatedTask(). completeTask() gets called after all the pending updates for a task are ACKed. i think it's better for these counters to reflect when a task transitions to terminal state instead of when its updates are acked. - Vinod Kone On May 12, 2014, 8:53 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21276/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 8:53 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1332 > https://issues.apache.org/jira/browse/MESOS-1332 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/slave/slave.hpp a6efad4763a7180daad63689227b46e196e5e1a9 > src/slave/slave.cpp 3a4ae38e06a1c23daafebf5421d996e649a07ca5 > > Diff: https://reviews.apache.org/r/21276/diff/ > > > Testing > ------- > > make check > > ran locally and manually verified > > > Thanks, > > Dominic Hamon > >
