----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21276/#review42871 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/21276/#comment76778> There should be a CHECK_NOTNULL(task) here. Alternatively, s/task->state()/state/ here and in the log statement in default. - Vinod Kone On May 13, 2014, 6:02 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21276/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 6:02 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1332 > https://issues.apache.org/jira/browse/MESOS-1332 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/slave/slave.hpp a6efad4763a7180daad63689227b46e196e5e1a9 > src/slave/slave.cpp 3a4ae38e06a1c23daafebf5421d996e649a07ca5 > > Diff: https://reviews.apache.org/r/21276/diff/ > > > Testing > ------- > > make check > > ran locally and manually verified > > > Thanks, > > Dominic Hamon > >
