----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/#review42875 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/21279/#comment76782> I would kill this. When a slave re-registers with a failed over master, it doesn't currently send information about completed executors or completed tasks of a running framework. It only sends info about completed frameworks (and their completed executors and tasks). So, updating the terminal task counts with the latter but not the former seems misleading. Lets update the counters after we fix the slave to do the right thing. - Vinod Kone On May 13, 2014, 7:35 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21279/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 7:35 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1332 > https://issues.apache.org/jira/browse/MESOS-1332 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > src/master/master.hpp 923552e3c7f9942d6be7a0446b44e40f53c11433 > src/master/master.cpp 569995c2eaf758f5171c4e0d082d4e519a143025 > > Diff: https://reviews.apache.org/r/21279/diff/ > > > Testing > ------- > > make check > > ran locally and manually verified. > > > Thanks, > > Dominic Hamon > >
